New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsublite): add client library metadata to headers #3458
Conversation
@codyoss: We'd like to send the pubsublite library version to the server for debugging purposes. |
c25ca8b
to
69f3ff1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment or else seems good to me. Only other thing is that I think we need to document these additional headers somewhere(internal). That way things can be consistent across languages and people can tell what the values mean. It is very possible this is already done and I am oblivious though.
…3458) Adds client library version and other properties to gRPC stream metadata for debugging purposes
Adds client library version and other properties to gRPC stream metadata for debugging purposes.